Handle empty selection in the MvxTableViewSource. Fixes #4897 #4901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b3573b8 to
80b1b41
Compare
80b1b41 to
46252cd
Compare
Cheesebaron
approved these changes
Jun 11, 2025
Contributor
Author
|
The changes seems to be approved, but not merged (and the branch become outdated since the approval time). Or I'm really missing something in the PR code which should be addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Bug fix. Ref. #4897
MvxTableViewSourcedoes not callSelectionChangedCommandwhen selection become empty.🆕 What is the new behavior (if this is a feature change)?
MvxTableViewSourcewill callSelectionChangedCommandwhen selection become empty, so developer can handle the empty selection.💥 Does this PR introduce a breaking change?
Yes. The
SelectionChangedCommandnow may be called in the situation where it was not called previously and with arguments likedefault(T)which might be not used previously.🐛 Recommendations for testing
See #4897 for the code sample. Pay attention to the case when you binding the collection of the value types.
📝 Links to relevant issues/docs
issue #4897
🤔 Checklist before submitting