Skip to content

Use new MCPProxyService in the server #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chelojimenez merged 3 commits into from
Jul 8, 2025
Merged

Use new MCPProxyService in the server #203

chelojimenez merged 3 commits into from
Jul 8, 2025

Conversation

@chelojimenez
Copy link
Contributor

@chelojimenez chelojimenez commented Jul 8, 2025 •
edited
Loading

Summary

  • Extracted transport management logic from main server into reusable MCPProxyService
  • Maintained full backward compatibility
  • Fixed connection issues and improved cleanup handling

Changes

  • Added: MCPProxyService class for centralized transport management
  • Added: TransportFactory for creating different transport types
  • Refactored: Main server routes to use MCPProxyService instead of inline transport logic
  • Fixed: Duplicate cleanup logs during connection teardown
  • Fixed: JSON parsing errors for shell command arguments

Technical Details

  • Maintains support for all transport types (STDIO, SSE, StreamableHTTP)
  • Preserves existing API endpoints and behavior
  • Adds connection lifecycle management with proper cleanup guards
  • Uses centralized logging and error handling

Testing

  • ✅ All existing functionality preserved
  • ✅ Connection creation and cleanup working correctly
  • ✅ No breaking changes to client interface

@chelojimenez chelojimenez changed the title Use new Use new MCPProxyService in the server Jul 8, 2025
@chelojimenez chelojimenez merged commit a1068c8 into main Jul 8, 2025
2 checks passed
khandrew1 pushed a commit that referenced this pull request Nov 15, 2025
@chelojimenez
Use new MCPProxyService in the server (#203)
3182c78 
* Refactor Main Server to use new proxy class

* Fix cleanup transport logic

* rm unused variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chelojimenez