I'd flip the condition, so that checking the box enables the randomness

There are a couple of reasons I didn't do that:

• Particles have had the randomness on by default ever since the particle element existed so that's the expected default behaviour
• This would require yet another converter that does nothing but tick a checkbox for existing particles

I'd flip the condition, so that checking the box enables the randomness

There are a couple of reasons I didn't do that:

* Particles have had the randomness on by default ever since the particle element existed so that's the expected default behaviour

* This would require yet another converter that does nothing but tick a checkbox for existing particles

Since this is a new parameter, there is no need for a converter. You can set the default value directly inside the Particle element constructor and select the checkbox inside initGUI (for reference, you can look at the hasBlockItem checkbox of plants and blocks)
For better clarity, we should probably avoid "Check to disable" checkboxes

Since this is a new parameter, there is no need for a converter. You can set the default value directly inside the Particle element constructor and select the checkbox inside initGUI (for reference, you can look at the hasBlockItem checkbox of plants and blocks) For better clarity, we should probably avoid "Check to disable" checkboxes

I tried this, but if you open an existing particle, the checkbox won't be checked, it will only be checked when creating a new particle

For better clarity, we should probably avoid "Check to disable" checkboxes

I thought Klemen didn't have an issue with them since he approved the "Disable gravity?" checkbox in the projectile ME

I tried this, but if you open an existing particle, the checkbox won't be checked, it will only be checked when creating a new particle

I guess a simpler solution would be to change the label to "Spawn particles with fixed size:" or similar

I thought Klemen didn't have an issue with them since he approved the "Disable gravity?" checkbox in the projectile ME

Probably means I should review PRs more often 😅

I thought Klemen didn't have an issue with them since he approved the "Disable gravity?" checkbox in the projectile ME

I guess I missed it. I agree with @AlsoSomeoneElse that it is better to not use it when possible as this can quickly be misread as we usually use "check to enable" text

Renamed the checkbox to "Spawn with no size variation?"

Would this be better?

Image for socials

Renamed the checkbox to "Spawn with no size variation?"

Would this be better?

Perfect!

Then in my opinion it doesn't make sense to do scale = 0.15f * fixed value, in my opinion we should do directly scale = fixed value when the option is enabled

This preserves original scale and is intended and was good idea to do so by the PR author