fix(fail2ban): escape percent signs in 3x-ipl datepattern#4328
Merged
Conversation
fix(fail2ban): escape percent signs in Docker datepattern
fix(fail2ban): escape percent signs in x-ui datepattern
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the pull request?
This PR escapes percent signs in the generated
3x-iplfail2ban filterdatepattern.A previous fix escaped
%in theactionban/actionunbandate commands, but the generatedfilter.d/3x-ipl.confstill contains:datepattern = ^%Y/%m/%d %H:%M:%SWhen
XUI_ENABLE_FAIL2BAN=trueis used in Docker, fail2ban can fail during startup with:This PR changes the generated datepattern to:
datepattern = ^%%Y/%%m/%%d %%H:%%M:%%Sin both
DockerEntrypoint.shandx-ui.sh.Which part of the application is affected by the change?
Type of Changes