Skip to content

update is_default_index logic#92

Merged
shouples merged 3 commits into
mainfrom
djs/concat-fix
Nov 3, 2022
Merged

update is_default_index logic#92
shouples merged 3 commits into
mainfrom
djs/concat-fix

Conversation

@shouples
Copy link
Copy Markdown
Collaborator

@shouples shouples commented Nov 3, 2022 •
edited
Loading

  • adds check for index.is_unique in is_default_index()
  • renames any instances of has_default_index to default_index_used

@shouples shouples self-assigned this Nov 3, 2022
@shouples shouples marked this pull request as ready for review November 3, 2022 15:11
@shouples shouples merged commit 025bbb2 into main Nov 3, 2022
@shouples shouples deleted the djs/concat-fix branch November 3, 2022 15:11
shouples added a commit that referenced this pull request Nov 14, 2022
@shouples
update is_default_index logic (#92)
705e95d 
* change has_default_index to default_index_used; pass default_index_used into build_table_schema's index arg

* update logic to check for unique index values

* consolidate tests
shouples added a commit that referenced this pull request Jan 6, 2023
@shouples
update is_default_index logic (#92)
80534de 
* change has_default_index to default_index_used; pass default_index_used into build_table_schema's index arg

* update logic to check for unique index values

* consolidate tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@shouples shouples

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@shouples