Make ID optional in ToolCallParam #366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52b1a39 to
966d743
Compare
Collaborator
|
Just for unification with other places, could we leave let container = try decoder.container(keyedBy: CodingKeys.self)
let parsingOptions = decoder.userInfo[.parsingOptions] as? ParsingOptions ?? []
// Some API providers for some AI models (e.g. openrouter.ai for Qwen model, mistral.ai for their models) don't return id and type parameters for ToolCallParam.
// See https://github.com/MacPaw/OpenAI/pull/366
self.id = try container.decodeString(forKey: .id, parsingOptions: parsingOptions) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
idparameter optional inToolCallParam.functiontype duringToolCallParamdecodingWhy
Some API providers for some AI models (such as
openrouter.aiforQwenmodel,mistral.aifor their models, and maybe others) don't returnidandtypeparameters forToolCallParam.Affected Areas
ToolCallParam.idparameter