Refactored getAllUnits to Simplify Logic and Added Unit Tests#5997
Merged
Conversation
Refactored the `getAllUnits` method by restructuring conditional logic and initializing `allUnits` at the declaration point, improving code clarity. Added comprehensive unit tests to validate the method's behavior across various scenarios, ensuring correctness for both standard and non-standard force cases.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5997 +/- ##
============================================
+ Coverage 10.32% 10.34% +0.02%
- Complexity 6113 6130 +17
============================================
Files 1038 1038
Lines 139294 139294
Branches 20662 20663 +1
============================================
+ Hits 14382 14412 +30
+ Misses 123468 123439 -29
+ Partials 1444 1443 -1 ☔ View full report in Codecov by Sentry. |
psikomonkie
reviewed
Feb 6, 2025
| @@ -0,0 +1,158 @@ | |||
| package mekhq.campaign.force; | |||
psikomonkie
approved these changes
Feb 6, 2025
psikomonkie
left a comment
Member
There was a problem hiding this comment.
Nice! I think I'll copy your comment style for Arrange, Act, and Assert - I think it helps make it more approachable.
NickAragua
approved these changes
Feb 7, 2025
HammerGS
approved these changes
Feb 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getAllUnitsmethod by restructuring conditional logic and initializingallUnitsat the declaration point, improving code clarity.Fix #5995