Corrected randomDeathMultiplier to use Double#5990
Merged
Conversation
Corrected RandomDeathMultiplier to use double instead of int. This ensures consistency with the spinner value type and prevents potential data loss or runtime errors.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5990 +/- ##
=========================================
Coverage 10.29% 10.29%
- Complexity 6108 6110 +2
=========================================
Files 1038 1038
Lines 139302 139302
Branches 20664 20664
=========================================
+ Hits 14337 14339 +2
Misses 123533 123533
+ Partials 1432 1430 -2 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrected
randomDeathMultiplierto use Double