Refactor shares percent to be polymorphic#6060
Merged
HammerGS merged 2 commits intoFeb 21, 2025
Merged
Conversation
rjhancock
approved these changes
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pretty simple change--to prepare for further work on cleaning up the Contract APIs, I've refactored
getSharesPercent()to simply be overridden by AtBContract rather than defining a new public function that "shouldn't be called" according to the old docstrings. This removes the hard dependency on AtBContract in Contract as it's no longer necessary to check what kind of object it is.I've also added a couple of basic tests to verify that the existing functionality has not changed.