Skip to content

Fixed Incorrect Seed Force in Resupply Interceptions#6102

Merged
HammerGS merged 1 commit into
MegaMek:masterfrom
IllianiBird:convoySeedForceDiscrepancy
Mar 1, 2025
Merged

Fixed Incorrect Seed Force in Resupply Interceptions#6102
HammerGS merged 1 commit into
MegaMek:masterfrom
IllianiBird:convoySeedForceDiscrepancy

Conversation

@IllianiBird

Copy link
Copy Markdown
Collaborator
  • Removed hardcoded convoy assignment.
  • Deployed Convoy to Area of Operations before generating the scenario. This allows the scenario to automatically pull in the convoy without extra handling. There is no risk of the convoy spawning extra scenarios in this manner.

Fix #6079

Dev Notes

I'm expecting this will make convoy interceptions significantly easier, so that will need to be monitored and addressed accordingly.

- Removed hardcoded convoy assignment.
- Deployed Convoy to Area of Operations _before_ generating the scenario. This allows the scenario to automatically pull in the convoy without extra handling. There is no risk of the convoy spawning extra scenarios in this manner.
@IllianiBird IllianiBird self-assigned this Feb 28, 2025
@codecov-commenter

codecov-commenter commented Feb 28, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.12%. Comparing base (394004e) to head (5468eeb).
Report is 29 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6102      +/-   ##
============================================
- Coverage     11.12%   11.12%   -0.01%     
+ Complexity     6426     6421       -5     
============================================
  Files          1062     1062              
  Lines        140441   140431      -10     
  Branches      20884    20884              
============================================
- Hits          15629    15624       -5     
+ Misses       123189   123183       -6     
- Partials       1623     1624       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psikomonkie psikomonkie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@HammerGS HammerGS merged commit e23a8b6 into MegaMek:master Mar 1, 2025
@IllianiBird IllianiBird deleted the convoySeedForceDiscrepancy branch March 23, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Issue] Stratcon generating XL force targeting Superheavy Support Vehicle convoy.

4 participants