Refactored Unable to Afford Expenses Dialog To Use Immersive Dialog Framework#6407
Merged
IllianiBird merged 4 commits intoMar 25, 2025
Conversation
…ramework - Replaced `AbstractMHQNagDialog` with `UnableToAffordExpensesNagDialog` for the `OutstandingScenariosNagDialog` class. - Updated dialog initialization logic to use constants and methods from `ImmersiveDialogNag`.
…mation on re-enabling suppressed warnings.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6407 +/- ##
=========================================
Coverage 11.30% 11.30%
- Complexity 6283 6285 +2
=========================================
Files 1071 1071
Lines 136136 136133 -3
Branches 21052 21052
=========================================
+ Hits 15385 15393 +8
+ Misses 119217 119204 -13
- Partials 1534 1536 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
# Conflicts: # MekHQ/resources/mekhq/resources/GUI.properties # MekHQ/resources/mekhq/resources/NagDialogs.properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AbstractMHQNagDialogwithUnableToAffordExpensesNagDialogfor theOutstandingScenariosNagDialogclass.ImmersiveDialogNag.Requirement
Requires #6401