Fix: Fixed Default Attribute Scores; Fixed Attribute Score Randomness; Reworked Attribute Score Randomness Option; Added Starting Attribute Score Documentation#6843
Merged
Conversation
…; Added Starting Attribute Score Documentation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6843 +/- ##
=========================================
Coverage 11.51% 11.52%
- Complexity 6563 6567 +4
=========================================
Files 1100 1100
Lines 140989 140971 -18
Branches 21848 21845 -3
=========================================
+ Hits 16237 16243 +6
+ Misses 123056 123030 -26
- Partials 1696 1698 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Scoppio
approved these changes
May 2, 2025
Scoppio
left a comment
Collaborator
There was a problem hiding this comment.
Could add a type of point-buy in a next iteration, and allow players to set the base point-buy stack in the campaign options. This can help with the all random stuff
Collaborator
Author
|
That'll be coming in 50.07/50.08, with the new company generator. But yeah, definitely on my radar. |
# Conflicts: # MekHQ/resources/mekhq/resources/CampaignOptionsDialog.properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dev Notes
There were a few issues with starting attribute scores. Namely that some of the scores were wrong (0, in some places, or 41 charisma for LAM Pilots).
Attribute score randomization also wasn't correctly resetting attribute scores to their default value before randomizing. What this would mean is that character attributes would frequently spike towards one extreme or the other.
Regarding attribute score randomization, I didn't like the play feel of the extra randomness option. Especially as we didn't have a non-random attribute option. So I reworked the 'extra randomness' option. That now just toggles randomness on/off.
Marking this as 'high' as it could have significant impact on a players' campaign if they upgrade a campaign from 50.05 or 50.06 to 50.07.