Fix: #6955 Fixed Personnel Cleanup to be More Reliable#6980
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6980 +/- ##
============================================
+ Coverage 12.03% 12.06% +0.03%
- Complexity 6889 6914 +25
============================================
Files 1103 1104 +1
Lines 142284 142299 +15
Branches 21991 21990 -1
============================================
+ Hits 17121 17168 +47
+ Misses 123328 123295 -33
- Partials 1835 1836 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #6955
We were checking for death and resignation dates, not statuses, causing the system to treat anyone who left the unit as if they had retired.
As this concerns the permanent removal of personnel from a campaign I'm marking this as draft to be merged into 50.07 and not 50.06. I've also added unit tests, which really should have been added when this was first developed, but at that time I didn't know how to write tests.