Improvement: Added Utility Methods to ReportingUtilities to Allow for Easier Application of Core Colors#7000
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7000 +/- ##
=========================================
Coverage 12.03% 12.03%
- Complexity 6889 6891 +2
=========================================
Files 1103 1103
Lines 142284 142287 +3
Branches 21991 21991
=========================================
+ Hits 17121 17124 +3
- Misses 123328 123332 +4
+ Partials 1835 1831 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
# Conflicts: # MekHQ/src/mekhq/gui/dialog/MekHQUnitSelectorDialog.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The three core colors: positive, warning, and negative were a right pain in the bum to use. As any time you wanted to use them you had to remember (or find)
MekHQ.getMHQOptions().getFontColorNegativeHexColor(). It was all very wordy and not easy to remember.Now just hit
ReportingUtilities.getPositiveColor()(or negative, or warning) and you're done.