Update Campaign.java to use Constant for Astech Team Size#7148
Merged
rjhancock merged 1 commit intoJun 7, 2025
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
The purpose of this PR is to update Campaign.java to replace a hard-coded value with a constant for calculating the Astech team size.
- Replaced the hard-coded multiplier (6) with MHQConstants.ASTECH_TEAM_SIZE in the getAstechNeed() method.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7148 +/- ##
=========================================
Coverage 12.49% 12.49%
+ Complexity 7379 7374 -5
=========================================
Files 1138 1138
Lines 146450 146373 -77
Branches 22456 22443 -13
=========================================
- Hits 18301 18295 -6
+ Misses 126269 126197 -72
- Partials 1880 1881 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Scoppio
approved these changes
Jun 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was working on my own fork and spotted a place in Campaign.java that had a hard coded value and didn't use the provide contast this changes from that value to use the constant, no other changes. I've tested locally and it works no issues.