Fix #7697: Fixed New Day Advance when Character is Illiterate But Has No Languages/Any Skill#7701
Merged
Merged
Conversation
…nguages/Any Skill
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7701 +/- ##
============================================
- Coverage 12.14% 12.14% -0.01%
+ Complexity 7321 7316 -5
============================================
Files 1210 1210
Lines 152464 152475 +11
Branches 23103 23107 +4
============================================
- Hits 18523 18516 -7
- Misses 132028 132047 +19
+ Partials 1913 1912 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
HammerGS
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #7697
This PR fixes an Advance Day error caused when a character is both Illiterate but also has no Languages/Any skill.
Giving the character Languages/Any (even at level 0) will work around this issue.