Skip to content

Fix #8426: Fixed Personnel Market Not Generating Initial Applicants on Campaign Start if Campaign Not Starting on 1st of Month#8431

Merged
HammerGS merged 1 commit into
MegaMek:mainfrom
IllianiBird:personnelMarketNewCampaignFix
Dec 6, 2025
Merged

Fix #8426: Fixed Personnel Market Not Generating Initial Applicants on Campaign Start if Campaign Not Starting on 1st of Month#8431
HammerGS merged 1 commit into
MegaMek:mainfrom
IllianiBird:personnelMarketNewCampaignFix

Conversation

@IllianiBird

Copy link
Copy Markdown
Collaborator

Fix #8426

…cants on Campaign Start if Campaign Not Starting on 1st of Month
@IllianiBird IllianiBird self-assigned this Dec 5, 2025
@IllianiBird IllianiBird requested a review from a team as a code owner December 5, 2025 20:49
@IllianiBird IllianiBird added Bug Severity: Medium Issues described as medium severity as per the new issue form labels Dec 5, 2025
@codecov

codecov Bot commented Dec 5, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 11.42%. Comparing base (aad0fcb) to head (6019694).
⚠️ Report is 87 commits behind head on main.

Files with missing lines Patch % Lines
MekHQ/src/mekhq/campaign/Campaign.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8431      +/-   ##
============================================
+ Coverage     11.40%   11.42%   +0.02%     
- Complexity     7319     7331      +12     
============================================
  Files          1278     1278              
  Lines        164203   164203              
  Branches      24740    24751      +11     
============================================
+ Hits          18730    18765      +35     
+ Misses       143544   143511      -33     
+ Partials       1929     1927       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Sleet01 Sleet01 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HammerGS HammerGS merged commit eb82157 into MegaMek:main Dec 6, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Severity: Medium Issues described as medium severity as per the new issue form

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Issue] Starting a campaign on a date that isn't the first of the month won't generate a starting personnel market line up

3 participants