Improvement: De-escalated Logger Clause for ACAR Orders#8452
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8452 +/- ##
=========================================
Coverage 11.40% 11.41%
- Complexity 7329 7335 +6
=========================================
Files 1281 1281
Lines 164600 164593 -7
Branches 24783 24777 -6
=========================================
+ Hits 18780 18784 +4
+ Misses 143896 143887 -9
+ Partials 1924 1922 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces logging verbosity by changing the log level from info to debug for ACAR (Auto-Combat Auto-Resolver) order creation. The change addresses log spam by moving detailed, non-human-readable object logging to the debug level, which is more appropriate for internal operational details.
Key Changes:
- Downgraded logging level for order addition from
infotodebuginOrderFactory.addOrder()
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
info->debugto reduce log spam of non-human readable objects