Skip to content

Fix #8471: Updated Campaign Options Iconography for 50.11 Dev Cycle#8485

Merged
IllianiBird merged 1 commit into
MegaMek:mainfrom
IllianiBird:campaignOptionsIcons
Dec 13, 2025
Merged

Fix #8471: Updated Campaign Options Iconography for 50.11 Dev Cycle#8485
IllianiBird merged 1 commit into
MegaMek:mainfrom
IllianiBird:campaignOptionsIcons

Conversation

@IllianiBird

@IllianiBird IllianiBird commented Dec 13, 2025

Copy link
Copy Markdown
Collaborator

Fix #8471

Purple Stars -> Green

@IllianiBird IllianiBird self-assigned this Dec 13, 2025
@IllianiBird IllianiBird requested a review from a team as a code owner December 13, 2025 01:05
@IllianiBird IllianiBird added GUI Campaign Options Relates to, or includes, campaign option changes labels Dec 13, 2025
@codecov

codecov Bot commented Dec 13, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 12.25%. Comparing base (cccdb9e) to head (29692bc).
⚠️ Report is 60 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8485      +/-   ##
============================================
+ Coverage     11.40%   12.25%   +0.84%     
- Complexity     7332     7357      +25     
============================================
  Files          1281     1285       +4     
  Lines        164625   165047     +422     
  Branches      24786    24815      +29     
============================================
+ Hits          18779    20226    +1447     
+ Misses       143923   142901    -1022     
+ Partials       1923     1920       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates campaign options iconography to reflect that certain features, previously marked as added in the development cycle, have now been included in the 50.11 milestone release. The changes convert purple filled stars (★) to green hollow stars (☆) throughout the Campaign Options dialog properties file, following the established convention where purple filled stars indicate "Added since the last Development release" and green hollow stars indicate "Added since the last Milestone release."

Key Changes:

  • Updated 47 campaign option labels from purple filled stars to green hollow stars
  • Color code changed from #C344C3 (purple) to #7FCF43 (green)
  • Star symbol changed from \u2605 (★) to \u2606 (☆)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Sleet01 Sleet01 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IllianiBird IllianiBird merged commit 0de5e05 into MegaMek:main Dec 13, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Campaign Options Relates to, or includes, campaign option changes GUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Issue] Updating purple stars in campaign options

3 participants