…sses #8620)

  ---
  Summary

  - Fixed transport cost double-counting display bug in contract payment breakdown
  - Changed transportAmount to represent employer's reimbursement (income) instead of player's cost
  - Better transport terms now correctly show improved contract value
  - Renamed "Transportation Amount" to "Transport Reimbursement" for clarity

  Background

  Transport cost confusion has come up multiple times on Discord, and has been discussed on the official forums:
  - https://battletech.com/forums/index.php?topic=90305.0
  - GitHub Issue: #8620 (partially addressed - see below)

  The Problem

  Players were experiencing confusing behavior when reviewing contract proposals:

  1. Double-counting appearance: Transport fees appeared to be subtracted twice - once in the Income section as "Transportation Amount" (showing the full transport cost as negative), and again in the Expenses section as "Transportation Expenses" (showing the player's share as negative). The breakdown values didn't add up to the displayed totals.
  2. Better terms = lower payout paradox: When negotiating better transport compensation (e.g., going from 50% to 75% employer-paid), the displayed payout would actually decrease. This was counterintuitive and made players think something was broken.
  3. Semantic confusion in code: The transportAmount field stored the player's out-of-pocket cost but was being added to income in getTotalAmount(), then subtracted again in getEstimatedTotalProfit(). While these operations cancelled mathematically, the display showed inconsistent values.

  Example: Before vs After

  Scenario: Full transport cost = 1,000,000 C-bills, Employer pays 50%

  | Display Section      | Before (Buggy)                   | After (Fixed)                                         |
  |----------------------|----------------------------------|-------------------------------------------------------|
  | Income: Transport    | -1,000,000 (full cost, negative) | +500,000 (reimbursement, positive)                    |
  | Expenses: Transport  | -500,000 (player's share)        | -1,000,000 (full cost you pay)                        |
  | Net effect on profit | Confusing, values don't add up   | Clear: +500k income - 1M expense = -500k (your share) |

  When negotiating better terms (75% employer-paid):

  | Metric                  | Before (Buggy)                  | After (Fixed)                              |
  |-------------------------|---------------------------------|--------------------------------------------|
  | Displayed payout        | Goes DOWN (confusing!)          | Stays similar                              |
  | Transport Reimbursement | Not shown correctly             | +750,000 (higher = better)                 |
  | Your transport cost     | -500,000 shown, -250,000 actual | -1,000,000 (full), offset by reimbursement |
  | Net profit effect       | Unclear                         | Clear: -250,000 (your 25% share)           |

  Regarding Issue #8620

  Issue #8620 reported that transport fees were deducted even when the player owns sufficient ships. This PR partially addresses that issue:

  - Fixed: The display now correctly shows what TransportCostCalculations returns. If you own ships, the calculated transport cost should be lower (or zero), and this will now display correctly.
  - Not addressed in this PR: During investigation, we found that ships which are "in transit" (not present at current location) still contribute to transport capacity calculations, even though they're not actually available. This is a separate issue that will be addressed in a follow-up PR.

  Test plan

  - Updated existing ContractTest cases for new calculation values
  - Added testGetEmployerTransportReimbursement - verifies employer reimbursement calculation
  - Added testGetPlayerTransportCost - verifies player's out-of-pocket cost
  - Added testGetTotalTransportationFees - verifies full transport cost returned
  - Added testTransportReimbursementWithPartialCompensation - tests 50% compensation
  - Added testBetterTransportTermsIncreaseReimbursement - verifies better terms = higher reimbursement
  - Manual testing: Verify contract proposal UI shows correct breakdown values
  - Manual testing: Verify owned ships reduce displayed transport costs

  🤖 Generated with https://claude.com/claude-code