Added Checkstyle GitHub Actions#8703
Merged
Merged
Conversation
Added Checkstyle to MM Data
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a dedicated GitHub Actions workflow to run Checkstyle checks aimed at license compliance and forbidden-word detection.
Changes:
- Introduces a new
checkstyle.ymlworkflow to run Gradle Checkstyle on PRs. - Tightens Checkstyle rules (severity adjustments and forbidden-word pattern updates).
- Adds a standard license header to
CanonicalDiseaseType.java.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
config/checkstyle/checkstyle.xml |
Updates regexp-based forbidden word and license checks; adjusts severities. |
MekHQ/src/mekhq/campaign/personnel/medical/advancedMedicalAlternate/CanonicalDiseaseType.java |
Adds license header to satisfy license-check enforcement. |
.github/workflows/checkstyle.yml |
Adds CI workflow intended to run Checkstyle on PRs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8703 +/- ##
============================================
+ Coverage 13.06% 13.13% +0.07%
- Complexity 7788 7826 +38
============================================
Files 1306 1306
Lines 168989 169092 +103
Branches 25398 25422 +24
============================================
+ Hits 22076 22213 +137
+ Misses 144785 144739 -46
- Partials 2128 2140 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Enabled Checkstyle checkouts for Data, MM, MML, and MHQ.
…ktyle-adjustments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds Checkstyle to GitHub Actions to ensure license compliance and forbidden word checks.