Give POW awards automatically at mission end#8939
Merged
HammerGS merged 2 commits intoMay 7, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8939 +/- ##
============================================
- Coverage 13.81% 13.81% -0.01%
+ Complexity 8187 8186 -1
============================================
Files 1284 1284
Lines 167636 167640 +4
Branches 25323 25323
============================================
- Hits 23162 23157 -5
- Misses 142142 142153 +11
+ Partials 2332 2330 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
IllianiBird
approved these changes
May 7, 2026
IllianiBird
left a comment
Collaborator
There was a problem hiding this comment.
autoAwards was my first major project, that it works at all is a miracle. Thanks for fixing this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, POW awards are never given automatically. The reason for this is that this award is based on the POW status of a person, but this status is cleared (just) before the auto awards are processed at mission end.
This PR fixes this issue by building a list of current POWs at mission end, and then using that list to determine which persons should get the award.
Unfortunately, due to the way auto awards are set up, this list needs to be passed on through several methods before it can actually be used to determine if a person should get the award. Overloaded methods help with this but it is still not ideal.