Fix/ No action Button text#4113
Merged
Merged
Conversation
…or the current usecase of our undo button
Contributor
Author
Screen.Recording.2025-09-20.at.5.48.46.PM.mov@tomasMizera this is how it looks without the text, but one thing I want to clarify is the UI for the formPhotoSketching, as you can see now it doesn't have a text and is a MMRoundButton, but the button background matches the actual background. While the similar left icon in the same window has white background used to make it distinguish, let me know what UI should be chosen for this specific case of the undo button. |
Pull Request Test Coverage Report for Build 17885305663Details
💛 - Coveralls |
tomasMizera
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
Removed text, as the button now switched from MMButton component to MMRoundButton component; which is more suitable.
MMRoundButton didn't have the enable/disable states, added property similar to MMButton to match the disable case.