Delete multiple features in bulk by kaustuvpokharel · Pull Request #4119 · MerginMaps/mobile

kaustuvpokharel · 2025-09-25T23:05:18Z

Case:

Multiselect feature exists, but there is no way to delete all selected multiple feature at once, so pr includes the deleteMultipleSelect feature

Fix:

Included feature deletion inside MultiEditManager class
//! Deletes selected or toggled features upon called Q_INVOKABLE void deleteSelectedFeature();
Changed UI with delete button with respected UI
Added the drawer to verify the deletion before actually deleting it

Tests:

Added test cases only for checking deletion feature inside the new file testmultieditmanager
Note: this file is incomplete in a sense that it is missing other feature test cases which already existed inside the MultiEditManager class, as I was only requested to add tests for my new feature addition. But it needs more test cases to test other prior existing functions/methods.

github-actions · 2025-09-25T23:29:41Z

Pull Request Test Coverage Report for Build 18636599772

Details

0 of 0 changed or added relevant lines in 0 files are covered.
1014 unchanged lines in 7 files lost coverage.
Overall coverage increased (+0.1%) to 19.756%

Files with Coverage Reduction	New Missed Lines	%
mm/app/attributes/attributecontroller.cpp	1	76.83%
mm/app/layerfeaturesmodel.cpp	1	79.5%
mm/core/merginapi.cpp	1	75.22%
mm/app/multieditmanager.h	2	0.0%
build-mm-db/app/Input_autogen/EWIEGA46WW/moc_multieditmanager.cpp	25	15.31%
mm/app/multieditmanager.cpp	42	50.4%
build-mm-db/app/.rcc/qmlcache/Input_qml/main_qml.cpp	942	0.0%

Totals
Change from base Build 18284755654:	0.1%
Covered Lines:	14047
Relevant Lines:	71104

💛 - Coveralls

tomasMizera

Tests + updates as discussed :)

…log info

kaustuvpokharel · 2025-10-01T23:46:41Z

This reverts commit 75fb005.

kaustuvpokharel · 2025-10-02T00:11:03Z

Screen.Recording.2025-10-01.at.8.09.53.PM.mov

Withalion

I still believe we can do better than using (s) in the text, maybe propagate through the signal if it's single or multi edit and then use ternary operator inline.

tomasMizera · 2025-10-02T13:21:29Z

I still believe we can do better than using (s) in the text, maybe propagate through the signal if it's single or multi edit and then use ternary operator inline.

https://doc.qt.io/qt-6/i18n-source-translation.html#handle-plural-forms

tomasMizera · 2025-10-02T13:22:30Z

Hi @kaustuvpokharel - we can close the multiselect drawer after features are deleted.

kaustuvpokharel · 2025-10-02T13:44:06Z

Noted

Dialog is not closed after deletion is done

Withalion

I would also add test for editing some points not just deleting

tomasMizera · 2025-10-09T16:40:46Z

Moving to 2025.8.0

Withalion

Just few more things

Withalion

Seems alright now, let's see what @tomasMizera thinks.

tomasMizera

Just a couple of minor comments :)

gabriel-bolbotina · 2025-11-20T07:45:31Z

I have added a scrollbar for the button text which might be larger than in English.

Future-proof in case of adding multiple functionality buttons.

Some use case scenarios are presented in these videos

tomasMizera

Looks good 👍🏻

tomasMizera · 2025-11-20T10:15:50Z

+
+    property int countToDelete: 0
+
+    title: qsTr( "Delete feature(s)", "", countToDelete )


Have you checked if the plural form works properly even without %n? :)

gabriel-bolbotina · 2025-11-21T16:01:09Z

For testing

For Android

V7a
V8a

For iOS

The build is number 25.11.826711

* added a button prototype, replecating editButton * working deleteFeature for multiselect * astyle code convention * added confirmation dialog for deletion * added missing safe bottom space for the drawer dialog * delete button (MMButton -UI changed to follow figma color * uncommented the commented lines for testing * changed the function according to feeback, fixed dialog texts, added log info * code convention failing * Revert "code convention failing" This reverts commit 75fb005. * minor code-conv-style fix * wrong push * applied suggested changes * new file could be targeted by cmake * test file conntected and working with the project * added test for multiEditManager class completely/focused for deleteMulipleSelected Feature and skipped some potential tests cases of the entire class(multieditmanager) * MultiSelectDrawer closed after the deletion * cleaned exiting code, and removed redundent dependencies * pural suggestion implemented * text suggestion applied * added suggested changes * Formatted code * Added scrollbar --------- Co-authored-by: Gabriel Bolbotina <bolbotinagabriel@gmail.com>

kaustuvpokharel added 7 commits September 25, 2025 19:02

added a button prototype, replecating editButton

41c5820

working deleteFeature for multiselect

e9fa016

astyle code convention

9a9cd47

added confirmation dialog for deletion

b3b4160

added missing safe bottom space for the drawer dialog

829b162

delete button (MMButton -UI changed to follow figma color

b26faae

uncommented the commented lines for testing

6a56c04

kaustuvpokharel linked an issue Sep 25, 2025 that may be closed by this pull request

Feature to delete multiple selected features at once #4097

Closed

kaustuvpokharel mentioned this pull request Sep 25, 2025

Feature to delete multiple selected features at once #4097

Closed

kaustuvpokharel marked this pull request as ready for review September 29, 2025 12:24

kaustuvpokharel requested review from Withalion and tomasMizera September 29, 2025 12:30

tomasMizera requested changes Sep 30, 2025

View reviewed changes

Comment thread app/qml/main.qml

Comment thread app/multieditmanager.h Outdated

kaustuvpokharel added 2 commits October 1, 2025 17:18

changed the function according to feeback, fixed dialog texts, added …

79b73ff

…log info

code convention failing

75fb005

kaustuvpokharel added 2 commits October 1, 2025 19:53

Revert "code convention failing"

56a6918

This reverts commit 75fb005.

minor code-conv-style fix

3f6ffcc

wrong push

af0d2f1

kaustuvpokharel requested a review from tomasMizera October 2, 2025 00:19

Withalion reviewed Oct 2, 2025

View reviewed changes

Comment thread app/multieditmanager.cpp Outdated

Comment thread app/multieditmanager.cpp

Comment thread app/multieditmanager.cpp

applied suggested changes

b38b6b7

Withalion previously approved these changes Oct 2, 2025

View reviewed changes

new file could be targeted by cmake

086e8b8

Withalion reviewed Oct 8, 2025

View reviewed changes

Withalion reviewed Oct 9, 2025

View reviewed changes

Comment thread app/qml/main.qml Outdated

tomasMizera changed the base branch from dev/2025.7.0 to dev/2025.8.0 October 10, 2025 11:49

kaustuvpokharel added 2 commits October 19, 2025 16:33

cleaned exiting code, and removed redundent dependencies

b0e585a

pural suggestion implemented

172276c

kaustuvpokharel requested a review from Withalion October 19, 2025 22:29

Withalion reviewed Oct 21, 2025

View reviewed changes

Comment thread app/qml/main.qml Outdated

Comment thread app/test/testmultieditmanager.cpp

text suggestion applied

5136978

kaustuvpokharel requested a review from Withalion October 21, 2025 17:28

Withalion force-pushed the dev/2025.8.0 branch from 75c3747 to eb72e98 Compare October 22, 2025 08:12

Withalion approved these changes Oct 22, 2025

View reviewed changes

tomasMizera reviewed Oct 28, 2025

View reviewed changes

Comment thread app/multieditmanager.h Outdated

Comment thread app/multieditmanager.cpp Outdated

Comment thread app/qml/gps/MMSelectionDrawer.qml Outdated

Comment thread app/qml/main.qml Outdated

added suggested changes

fd7d418

tomasMizera changed the title ~~Feature/delete multiple feature~~ Delete multiple features in bulk Nov 7, 2025

Withalion changed the base branch from dev/2025.8.0 to master November 11, 2025 10:01

tomasMizera assigned gabriel-bolbotina Nov 17, 2025

gabriel-bolbotina added 2 commits November 19, 2025 09:05

Formatted code

0b3dbc9

Merge branch 'master' into feature/deleteMultipleFeature

dd53c26

gabriel-bolbotina force-pushed the feature/deleteMultipleFeature branch from 12e5b14 to dd53c26 Compare November 19, 2025 10:40

Added scrollbar

726a8ab

gabriel-bolbotina requested a review from tomasMizera November 20, 2025 07:46

tomasMizera approved these changes Nov 20, 2025

View reviewed changes

gabriel-bolbotina merged commit 48c5659 into master Nov 21, 2025
12 checks passed

gabriel-bolbotina deleted the feature/deleteMultipleFeature branch November 21, 2025 07:38


		property int countToDelete: 0

		title: qsTr( "Delete feature(s)", "", countToDelete )

Conversation

kaustuvpokharel commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 18636599772

Details

💛 - Coveralls

Uh oh!

tomasMizera left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kaustuvpokharel commented Oct 1, 2025

Uh oh!

kaustuvpokharel commented Oct 2, 2025

Uh oh!

Withalion left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tomasMizera commented Oct 2, 2025

Uh oh!

tomasMizera commented Oct 2, 2025

Uh oh!

kaustuvpokharel commented Oct 2, 2025

Uh oh!

Withalion left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tomasMizera commented Oct 9, 2025

Uh oh!

Withalion left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Withalion left a comment

Choose a reason for hiding this comment

Uh oh!

tomasMizera left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gabriel-bolbotina commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tomasMizera left a comment

Choose a reason for hiding this comment

Uh oh!

tomasMizera Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gabriel-bolbotina commented Nov 21, 2025

For testing

For Android

For iOS

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

kaustuvpokharel commented Sep 25, 2025 •

edited

Loading

github-actions Bot commented Sep 25, 2025 •

edited

Loading

gabriel-bolbotina commented Nov 20, 2025 •

edited

Loading