CDDSO-631 Fix for archiving when sub-experiment id is not none#434
Merged
Matthew Mizielinski (matthew-mizielinski) merged 2 commits intoMar 17, 2025
Merged
Conversation
…rectory pathwhen archiving
mo-kerstinschmatzer
approved these changes
Mar 17, 2025
Collaborator
mo-kerstinschmatzer
left a comment
There was a problem hiding this comment.
Lgtm to me. Tests passed
Collaborator
Author
|
merged into main in 7b318a3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Between v2.5.8 and v3.1.0 something has changed in the code that constructs the member id for use in the archiving, leading to a sequence of directories such as
This is down to the update_memberid_if_needed() function in cdds.archive.mass being repeatedly applied and not checking if the member id had already been constructed correctly.
Change includes fix plus some tests.