Skip to content

Configurable showcases#144

Open
cosunae wants to merge 28 commits into
mainfrom
general_meteogram
Open

Configurable showcases#144
cosunae wants to merge 28 commits into
mainfrom
general_meteogram

Conversation

@cosunae
Copy link
Copy Markdown
Contributor

@cosunae cosunae commented May 1, 2026 •
edited
Loading

The idea is to make the generation of showcases configurable.
In the config we can now specify:

  • whether we activate the generation of showcase animations and/or meteograms:
  • a list of locations
  • the region, by name a custom configured extent/projection
  • the parameters

An example

showcase:
  params:
    - T_2M
    - SP_10M
    - TOT_PREC
  meteograms: false
  animations: true
  regions:
    - europe
    - switzerland
    - name: alpine_arc
      extent: [-16.0, 25.0, 30.0, 65.0]
      projection: orthographic

  stations: [JUN, COV, GOR, WFJ, SAE, SAM, DAV, ZER, ANT, VSBAS, BRT, LTB, GOS, CEV, BIA]

Louis-Frey and others added 14 commits April 22, 2026 09:05
@Louis-Frey @frazane
@MicheleCattaneo @hlasco @clairemerker
Add inference + experiment configs for new ICON-REA-L interpolator
d2a75ef 
Co-authored-by: Francesco Zanetta <62377868+frazane@users.noreply.github.com>
Co-authored-by: Michele Cattaneo <44707621+MicheleCattaneo@users.noreply.github.com>
Co-authored-by: Hugues de Laroussilhe <hugues.delaroussilhe@meteoswiss.ch>
@jonasbhend @clairemerker
Renamed interpolator config and switch to hourly baseline
f60a9ab
@jonasbhend @clairemerker
Remove intermediate configs
5f86d81
@jonasbhend
Add accumulation post-processor to ensure that TOT_PREC is accumulate…
5a24380 
…d (as in baseline)
@jonasbhend
Update checkpoints and baselines
ba0029b
@jonasbhend
Fix trailing whitespace
31fcb65
@jonasbhend
Inlined debugging comments and remove debugging text file
91cdf61
@jonasbhend
move computation to inner loop to avoid dask graph bloat
0088c37
@jonasbhend
Use allocated CPU resources in dataset computation
9b07bd0
@jonasbhend @dnerini
Update config/interpolators-ich1-balfrin.yaml
7b0b247 
Co-authored-by: Daniele Nerini <daniele.nerini@meteoswiss.ch>
@jonasbhend @dnerini
Update config/interpolators-ich1-balfrin.yaml
7fcbf8a 
Co-authored-by: Daniele Nerini <daniele.nerini@meteoswiss.ch>
@jonasbhend
renamed interpolator config
2d25a53
@cosunae
generalize the plot of meteograms to any location
24848f1
@cosunae
Merge branch 'main' into general_meteogram
d162b37
cosunae
cosunae commented May 1, 2026
View reviewed changes
Comment thread workflow/Snakefile Outdated
jonasbhend
jonasbhend requested changes May 4, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jonasbhend jonasbhend left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good (from looking at it). Will test once balfrin is back online. Could you please include the example config in the code base (e.g. in interpolators-ich1.yaml), otherwise it might be lost.

jonasbhend
jonasbhend reviewed May 5, 2026
View reviewed changes
Comment thread config/interpolators-ich1.yaml Outdated
@cosunae
Copy link
Copy Markdown
Contributor Author

cosunae commented May 6, 2026

@jonasbhend did you have the chance to look at it?

jonasbhend
jonasbhend requested changes May 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jonasbhend jonasbhend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cosunae, really nice. I have a minor discussion point (not sure whether we want to do this at all) and there seems to be something wrong with the precipitation scaling in the example config (run as is for meteograms only):

Image

Comment thread config/interpolators-ich1.yaml Outdated
jonasbhend
jonasbhend reviewed May 7, 2026
View reviewed changes
Comment thread workflow/rules/plot.smk
@jonasbhend jonasbhend changed the title General meteogram Configurable showcases May 7, 2026
@jonasbhend jonasbhend mentioned this pull request May 7, 2026
Open
1 task
@cosunae
Copy link
Copy Markdown
Contributor Author

cosunae commented May 7, 2026 •
edited
Loading

Thanks @cosunae, really nice. I have a minor discussion point (not sure whether we want to do this at all) and there seems to be something wrong with the precipitation scaling in the example config (run as is for meteograms only):

Image

thanks @jonasbhend , not sure I understood what would you do here?
It looks like CH2 shows very weird values probably due to the remapping of the grids and the nature of precip, but not sure what you would do with the scale?
Other examples look more reasonable... ?

202503270600_TOT_PREC_JUN

@cosunae
Copy link
Copy Markdown
Contributor Author

cosunae commented May 18, 2026

@jonasbhend is there any other comment on this?
I proposed a different PR for the optimization to unify the processing of regions and locations here:
#154

jonasbhend
jonasbhend reviewed May 18, 2026
View reviewed changes
Comment thread config/interpolators-ich1.yaml
projection: orthographic
thresholds:
TOT_PREC:
gt: [0.0, 0.001, 0.005]
Copy link
Copy Markdown
Contributor

@jonasbhend jonasbhend May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to use the new units, TOT_PREC is now in mm (so thresholds should probably be [0.0, 1.0, 5.0]

Copy link
Copy Markdown
Contributor Author

@cosunae cosunae May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, where this change in the units came from? Because these values are in the main, should we do this in a different PR?

jonasbhend
jonasbhend approved these changes May 18, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jonasbhend jonasbhend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cosunae Good to go after fixing the thresholds (due to change in units) for TOT_PREC in config

This was referenced May 18, 2026
Open
Open
@jonasbhend
Copy link
Copy Markdown
Contributor

jonasbhend commented May 19, 2026

Thanks @cosunae, really nice. I have a minor discussion point (not sure whether we want to do this at all) and there seems to be something wrong with the precipitation scaling in the example config (run as is for meteograms only):
Image

thanks @jonasbhend , not sure I understood what would you do here? It looks like CH2 shows very weird values probably due to the remapping of the grids and the nature of precip, but not sure what you would do with the scale? Other examples look more reasonable... ?

202503270600_TOT_PREC_JUN

No need to do anything about it in this PR.

@jonasbhend jonasbhend closed this May 19, 2026
@jonasbhend jonasbhend reopened this May 20, 2026
@jonasbhend
Copy link
Copy Markdown
Contributor

jonasbhend commented May 20, 2026

Sorry @cosunae I inadvertently closed this (probably due to my heavily lagging connection yesterday). As said, this is good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonasbhend jonasbhend jonasbhend approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cosunae @jonasbhend @Louis-Frey