fix(agent): file save encoding issue, add encoding parameter when save file to avoid env issue #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o avoid env issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe this PR
当保存日志文件的时候，会出现错误
由于不同操作系统默认的文件编码格式不一样，所以python编码规范最佳实践建议，使用file save时必须传递encoding参数以避免此类错误
采用更为通用的utf8编码，可兼容中英文和大多数语言
What changed?
采用更为通用的utf8编码，可兼容中英文和大多数语言
Why?
Related issues
#100
#102
Checklist for PR
Write a descriptive PR title following the [Angular commit message format]
fix(encoding): add encoding parameter when save file to avoid env issue
Run lint and format locally:
uv tool run ruff@0.8.0 check --fix .uv tool run ruff@0.8.0 format .lintenforces ruff default format/lint rules on all new codes.