Skip to content

bnrh matlab vs fortran del_q #1127

@hkershaw-brown

Description

@hkershaw-brown

I'm not sure if this is a bug, but the del_q is calculated differently in the Matlab and Fortran versions of bnrh_cdf

Fortran has del_q = 1.0_r8 / (ens_size + 1.0_r8)

! For unit normal, find distance from mean to where cdf is 1/(ens_size+1) (del_q_.
! Saved to avoid redundant computation for repeated calls with same ensemble size
del_q = 1.0_r8 / (ens_size + 1.0_r8)

Matlab has del_q = 1.0 / (ens_size + 1.8)

% For unit normal, find distance from mean to where cdf is 1/(ens_size+1) (del_q_.
% Saved to avoid redundant computation for repeated calls with same ensemble size
del_q = 1.0 / (ens_size + 1.8);

which I suspect is a copy/past error of 1.0r8 but I might be missing something

Metadata

Metadata

Labels

BugSomething isn't working

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions