Skip to content

fix: del_q calculation use ens_size +1#1129

Open
hkershaw-brown wants to merge 1 commit into
mainfrom
dartlab-bnrh-fix
Open

fix: del_q calculation use ens_size +1#1129
hkershaw-brown wants to merge 1 commit into
mainfrom
dartlab-bnrh-fix

Conversation

@hkershaw-brown

Copy link
Copy Markdown
Member

Description:

This pull request fix a in matlab DART_LAB for the calculation of del_q which was using 1.8 instead on 1.0.

Fixes issue

fixes #1127

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Documentation changes needed?

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Tests

Please describe any tests you ran to verify your changes.
No tests, just sanity check bounded_oned_ensemble gui bnrhf was not catastrophically broken.

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Update conf.py

Checklist for release

  • Merge into main
  • Create release from the main branch with appropriate tag
  • Delete feature-branch

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed

@hkershaw-brown hkershaw-brown requested a review from jlaucar June 12, 2026 14:11
@hkershaw-brown hkershaw-brown added the release! bundle with next release label Jun 12, 2026

@jlaucar jlaucar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is obviously a typo. Fix is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release! bundle with next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bnrh matlab vs fortran del_q

2 participants