Skip to content

Fix - Overflow on dropdown bug selector #1762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Pedr0-Moreira wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix - Overflow on dropdown bug selector #1762

Pedr0-Moreira wants to merge 2 commits into from

Conversation

@Pedr0-Moreira
Copy link

@Pedr0-Moreira Pedr0-Moreira commented Dec 11, 2025

Closes #1706

Review checklist

  • Terms and conditions reflect the changes

View Changes

  • Description has screenshots of the UI changes.
  • Tested both in light and dark mode.
  • New text is both in portuguese (PT) and english (EN).
  • Works in different text zoom levels.
  • Works in different screen sizes.

Performance

  • No helper functions to return widgets are added. New widgets are created instead.
  • Used ListView.builder for Long Lists.
  • Controllers (TextEditingController, ...) are beeing disposed of in dispose() method.

@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60%. Comparing base (df5f88d) to head (3c60462).
⚠️ Report is 1 commits behind head on develop.

❌ Your project check has failed because the head coverage (60%) is below the target coverage (70%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files 
@@           Coverage Diff           @@
##           develop   #1762   +/-   ##
=======================================
  Coverage       60%     60%           
=======================================
  Files            2       2           
  Lines           81      81           
=======================================
  Hits            48      48           
  Misses          33      33
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Pedr0-Moreira
Copy link
Author

Pedr0-Moreira commented Dec 11, 2025 •
edited
Loading

Screenshot_2025-12-11-16-25-11-50_60e37a1aeb7cf318865f37f1a98a6984.jpg
Changed horizontal padding from 50 to 30

jcovaa
jcovaa approved these changes Dec 12, 2025
View reviewed changes
Copy link
Contributor

@jcovaa jcovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcovaa jcovaa jcovaa approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Overflow on dropdown bug selector

3 participants

@Pedr0-Moreira @jcovaa