-
Notifications
You must be signed in to change notification settings - Fork 13
ATLAS_PH_13TEV_139fb #2339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
ATLAS_PH_13TEV_139fb #2339
Conversation
|
I have a few questions regarding this dataset: Regarding this dataset, should I change figure_by from 'eta' to 'radius' in the metadata file? Given that the two subfigures I'm implementing are differentiated by radius. Also, should I add 'radius' as a variable in the kinematic coverage? Finally, is there not a rapidity bin missing? namely 1.37 < eta < 1.56? For reference, the HEPData link: https://www.hepdata.net/record/ins2628741 And the figure: |
For the kinematic variables, Then, regarding the rest. I'd say these are either two different observables or two variants (@enocera should decide), but the radius is not part of the kinematic variables. @enocera another question, does this measurement makes the other 13 TeV photon that we have obsolete? i.e., when running grids, do you want me to focus on this one? |
|
@vschutze-alt (cc @scarlehoff ) Concering the radius, I think that here the situation is similar to that we have with single-inclusive jet or di-jet production, in which indeed we can have two versions of the same data set that differ for the jet radius. In that case we have implemented two variants of the same data set, therefore I would do the same here. To have an idea of how a variant works in this case, you can have a look at |
0212b69 to
54345c4
Compare
…d uncertainty variants; added c.m. energy
…ncertainties; added bin limits; added c.m. energy, even if not needed
enocera
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dear @VLTSML26 I have revised this PR. I've made the following alterations.
metadata.yaml: I have corrected a typo in the journal name; I have changed the names of the observables; I have added the c.m. energy (even if not required) in the kinematic specifications; I have added the (provisional) theory block.data*,kinematics*anduncertainteis*files: the names are modified according to the new names of the observables; note that, after a careful look at the paper, I came to a slight different conclusion on the uncorrelated systematic uncertainties. Note that I set all the uncorrelated uncertainties to theADDtreatment. They indeed look of statistical origin, therefore it seems more appropriate for them to be additive. I have left a comment about that in filter.py.filter.py: I have changed a little the way in which the data is parsed, and I have implemented the new names for the observables.
Note that tests are now passing (I suspect that there was a kinematic mismatch).
| - observable_name: ET-ETA-R02 | ||
| observable: | ||
| description: "ATLAS direct photon production 13 TeV at 139 fb^-1 R=0.2" | ||
| label: r"dsigma/dE_T^\gamma" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is differential in both I think the label should also have d\eta
No description provided.