Handle two quantification table folders of GNPS feature-based workflow #275
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @CunliangGeng and the rest of your teammates on |
This was referenced Sep 16, 2024
Member
Author
gcroci2
approved these changes
Sep 17, 2024
Member
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dora found the following issue:
GNPS FEATURE-BASED-MOLECULAR-NETWORKING workflow might output two folders for quantification table with folder name:
quantification_tablequantification_table_reformattedIn this case, NPLinker will raise an error. However, NPLinker is expected to pick one folder and process the data.
This PR changes NPLinker to make it always first pick the
quantification_table_reformattedfolder, if this folder does not exist, then pickquantification_tablefolder to process the data. If neither exist, raise an error.