Skip to content

remove default config file to make all settings explicit#287

Merged
CunliangGeng merged 6 commits into
devfrom
add_config_auto
Nov 27, 2024
Merged

remove default config file to make all settings explicit#287
CunliangGeng merged 6 commits into
devfrom
add_config_auto

Conversation

@CunliangGeng

@CunliangGeng CunliangGeng commented Nov 27, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

A default config file nplinker_default.toml was used automatically in NPLinker. However, it may lead to two problems:

  1. The use of default settings cause confusions to users who might not be aware of them.
  2. It requires users to be familiar with Dynaconf to config their own settings

This PR removes the default config file and let users to config all settings in their config file nplinker.toml.

@CunliangGeng Graphite App

CunliangGeng commented Nov 27, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@CunliangGeng CunliangGeng mentioned this pull request Nov 27, 2024
Merged
@CunliangGeng CunliangGeng requested a review from gcroci2 November 27, 2024 14:31
@CunliangGeng CunliangGeng self-assigned this Nov 27, 2024
@CunliangGeng CunliangGeng linked an issue Nov 27, 2024 that may be closed by this pull request
Use bigscape version in loaders #271
Closed
@CunliangGeng CunliangGeng marked this pull request as ready for review November 27, 2024 14:31
@CunliangGeng Graphite App

CunliangGeng commented Nov 27, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

Merge activity

  • Nov 27, 11:20 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 27, 11:23 AM EST: Graphite rebased this pull request as part of a merge.
  • Nov 27, 11:24 AM EST: A user merged this pull request with Graphite.

@CunliangGeng CunliangGeng changed the base branch from add_support_mibigv4 to graphite-base/287 November 27, 2024 16:21
@CunliangGeng CunliangGeng changed the base branch from graphite-base/287 to dev November 27, 2024 16:21
@CunliangGeng CunliangGeng merged commit d9a4745 into dev Nov 27, 2024
@CunliangGeng CunliangGeng deleted the add_config_auto branch November 27, 2024 16:24
@sonarqubecloud

sonarqubecloud Bot commented Nov 27, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
11.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gcroci2 gcroci2 gcroci2 approved these changes

Assignees

@CunliangGeng CunliangGeng

Labels

None yet

Projects

dev
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use bigscape version in loaders

2 participants

@CunliangGeng @gcroci2