Reduce memory footprint #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace dictionary of dictionaries with a dictionary of composite keys, using a struct.
Eliminate a dictionary per tuple and use a single dictionary in the working memory with a composite key.
Store activation-related state needed for on-change agenda filters to the filters, to reduce the memory footprint associated with activations. Generalize the concept of stateful agenda filters, such that custom filters can be added in the future.
Eliminate LINQ Store keys in arrays; pre-allocate those arrays once, and use Array.Copy to snap new keys
To improve propagation performance and reduce memory footprint
Remove activation change keys from the KeyChange agenda filter when the activation is removed. Cleanup naming. Create AgendaContext once and reuse to eliminate allocations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For simple rules (without complex joins and aggregations) this reduces the memory utilization down to a half of what it was.
This improvement does not affect aggregations.