Skip to content

Update error regex for topk in opinfo_input_generators.py #5694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
zasdfgbnm wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update error regex for topk in opinfo_input_generators.py #5694

zasdfgbnm wants to merge 2 commits into from

Conversation

@zasdfgbnm
Copy link
Collaborator

@zasdfgbnm zasdfgbnm commented Dec 17, 2025

No description provided.

@zasdfgbnm
Copy link
Collaborator Author

zasdfgbnm commented Dec 17, 2025

!test

@github-actions
Copy link

github-actions bot commented Dec 17, 2025 •
edited by xwang233
Loading

Review updated until commit 74e402f

Description

  • Updated error regex pattern in topk_error_generator function

  • Changed from specific "selected index k out of range" to general "k .* range"

  • Fixes pattern matching for PyTorch runtime errors in topk operations

  • Ensures proper error detection in opinfo input generation tests

Changes walkthrough
Relevant files
Bug fix
opinfo_input_generators.py
Update error regex pattern for topk error matching             

tests/python/opinfo/opinfo_input_generators.py

  • Updated error regex pattern in topk_error_generator function
  • Changed from "selected index k out of range" to "k .* range"
  • Makes error matching more robust for PyTorch topk operations
    		• +1/-3     

    PR Reviewer Guide

    Here are some key observations to aid the review process:

    🧪 PR contains tests
    ⚡ Recommended focus areas for review
    Regex Pattern Validation

    The error regex pattern was changed from "selected index k out of range" to "k .* range". This is a significant change in pattern specificity that should be validated to ensure it correctly matches the intended error messages while not being overly broad. The new pattern "k .* range" is more general and could potentially match unintended error messages.

    yield SampleInput(a, 16, 1, True, False), RuntimeError, "k .* range"

    Test failures

    • (Medium, 1) CUDA out-of-memory in nvFuser TmaPointwiseTestF.SplitGridDim2D on H100

      Test Name H100 Source
      TmaPointwiseTestF.SplitGridDim2D ❌ Link

    @zasdfgbnm
    Copy link
    Collaborator Author

    zasdfgbnm commented Dec 17, 2025

    !test

    @zasdfgbnm zasdfgbnm marked this pull request as ready for review December 17, 2025 19:17
    @zasdfgbnm zasdfgbnm changed the title Update error regex in for topk in opinfo_input_generators.py Update error regex for topk in opinfo_input_generators.py Dec 17, 2025
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    No reviews

    Assignees

    No one assigned

    Labels

    None yet

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    2 participants

    @zasdfgbnm