tests/unittest/llmapi/test_sampling_params.py (2)

58-63: ⚡ Quick win

Add explicit return annotations to updated test/helper functions.

Please add -> None to the changed test functions and a concrete return annotation for FakeTokenizer.encode to align with repo typing standards.

Suggested patch

-def test_completion_logprobs_assignment_revalidates():
+def test_completion_logprobs_assignment_revalidates() -> None:
@@
-def test_thinking_token_budget_unlimited_values(value):
+def test_thinking_token_budget_unlimited_values(value: int | None) -> None:
@@
-def test_thinking_token_budget_rejects_invalid_values(value):
+def test_thinking_token_budget_rejects_invalid_values(value: object) -> None:
@@
-def test_chat_thinking_token_budget_request_validation():
+def test_chat_thinking_token_budget_request_validation() -> None:
@@
-def test_thinking_budget_logits_processor_forces_end_token():
+def test_thinking_budget_logits_processor_forces_end_token() -> None:
@@
-def test_thinking_budget_logits_processor_completes_partial_end_sequence():
+def test_thinking_budget_logits_processor_completes_partial_end_sequence() -> None:
@@
-def test_thinking_budget_logits_processor_ignores_partial_end_before_budget():
+def test_thinking_budget_logits_processor_ignores_partial_end_before_budget() -> None:
@@
-def test_thinking_budget_logits_processor_ignores_closed_reasoning_block():
+def test_thinking_budget_logits_processor_ignores_closed_reasoning_block() -> None:
@@
-def test_add_thinking_budget_logits_processor_uses_reasoning_parser_tokens():
+def test_add_thinking_budget_logits_processor_uses_reasoning_parser_tokens() -> None:
     class FakeTokenizer:
-        def encode(self, text, add_special_tokens=False):
+        def encode(self, text: str, add_special_tokens: bool = False) -> list[int]:
             del add_special_tokens

As per coding guidelines, “Static type checking with mypy is opt-in by submodule; always annotate functions with return types (use None if function does not return)”.

Also applies to: 65-169

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/unittest/llmapi/test_sampling_params.py` around lines 58 - 63, Add
explicit return type annotations to the modified test and helper functions:
append "-> None" to any test functions in the updated block (the tests around
request.to_sampling_params checks) and to other test helpers in the 65-169
region, and add a concrete return annotation to FakeTokenizer.encode (e.g., ->
List[int] or -> Sequence[int] consistent with project typing) so all functions
have explicit return types per the repo's mypy guidance; update imports if
needed for typing names.

---

65-169: QA list updates are unnecessary for this PR scope.

These are unittest/API-stability changes only, so no tests/integration/test_lists/qa/* update is required in this PR.

As per coding guidelines, “If the PR only touches unittest/ or narrow unit scope, say explicitly whether QA list updates are unnecessary or optional.”

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/unittest/llmapi/test_sampling_params.py` around lines 65 - 169, The PR
touches only unit tests and API-stability tests (e.g.,
test_thinking_token_budget_unlimited_values,
test_thinking_budget_logits_processor_*, SamplingParams,
add_thinking_budget_logits_processor), so explicitly state in the PR description
(or commit message) that QA list updates are unnecessary for this change; add a
single-line note in the PR body like “QA list updates unnecessary: changes
limited to unittest/API-stability” and optionally add a one-line comment at the
top of the modified test module to record that scope for future reviewers.