This repository was archived by the owner on Mar 21, 2024. It is now read-only.
Eliminate device synchronization in CDP version of segmented sort#445
Merged
alliepiper merged 2 commits intoMar 24, 2022
Merged
Conversation
alliepiper
suggested changes
Mar 21, 2022
alliepiper
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, some minor updates needed.
Contributor
|
The (simple) test code from #409 is working. |
6e18000 to
becd6fa
Compare
alliepiper
added a commit
to alliepiper/thrust
that referenced
this pull request
Mar 22, 2022
Collaborator
|
gpuCI: NVIDIA/thrust#1641 |
Collaborator
|
Will need to restart tests later, looks like the github outage is affecting things at the moment. |
alliepiper
added a commit
to alliepiper/thrust
that referenced
this pull request
Mar 23, 2022
alliepiper
approved these changes
Mar 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR eliminates the device-side usage of the
cudaDeviceSynchronizefunction which was depricated in the CUDA Toolkit 11.6. Since in the #409 @fkallen reported usage of the segmented soft in the CDP mode, it whould be great if @fkallen could verify the changes.