This repository was archived by the owner on Mar 21, 2024. It is now read-only.
Document segmented sort behaviour for unspecified ranges#519
Merged
gevtushenko merged 1 commit intoJul 19, 2022
Merged
Conversation
jrhemstad
approved these changes
Jul 18, 2022
jrhemstad
left a comment
Collaborator
There was a problem hiding this comment.
Some ideas for making the requirements stronger/clearer.
I'll approve and defer to whatever you end up feeling is best.
beaaa51 to
8612529
Compare
8612529 to
b665d6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issue by documenting segmented sort behaviour in case of unspecified ranges. It also adds tests to ensure this behaviour.