This repository was archived by the owner on Mar 21, 2024. It is now read-only.
Fix some min/max macro collisions with windows.h#393
Merged
Conversation
cf45890 to
d923f95
Compare
Collaborator
Author
|
Marking draft -- there are some issues with these macros I'll need to address before review. |
2c1d167 to
89ec3cf
Compare
gevtushenko
approved these changes
Oct 26, 2021
gevtushenko
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. There's one cleaning-up suggestion which we can address later.
89ec3cf to
a42d1e3
Compare
Tried adding these to the header test macro checks, but this introduced new issues on non-msvc builds. We can revist the header tests later, this PR just fixes the collisions.
a42d1e3 to
69079eb
Compare
Collaborator
Author
|
Testing in NVIDIA/thrust#1552. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.