fix: do not await slack when handling function success#5175
Merged
Conversation
Some calls to slackService were still being awaited. We don't want to await SlackService function to prevent delaying the functions result processing when Slack is slow/ratelimiting/unresponsive. Other call to SlackService in the same files were already not awaited
🤖 My Senior Dev2 files reviewed • 1 need attention
💬 Try: 📖 All commands & personasYou can interact with me by mentioning In PR comments or on any line of code:
Slash commands:
AI Personas (mention to get their perspective):
For the best experience, view this PR on myseniordev.com — includes AI chat, file annotations, and interactive reviews. |
marcindobry
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some calls to slackService were still being awaited. We don't want to await SlackService function to prevent delaying the functions result processing when Slack is slow/ratelimiting/unresponsive. Other call to SlackService in the same files were already not awaited
Avoid awaiting Slack cleanup during success handlers
Updates
handleActionSuccessand the sync success flow to fire-and-forgetslackService.removeFailingConnectionso Slack latency does not delay job completion. Aligns these success paths with other non-blocking Slack invocations already present in the codebase.Key Changes
• Switched
slackService.removeFailingConnectionto run viavoidinpackages/jobs/lib/execution/action.tssuccess handler• Applied the same non-blocking pattern in
packages/jobs/lib/execution/sync.tssuccess handlerAffected Areas
• packages/jobs/lib/execution/action.ts
• packages/jobs/lib/execution/sync.ts
This summary was automatically generated by @propel-code-bot