fix(logs): allow year to be set as well#5206
Merged
khaliqgant merged 1 commit intomasterfrom Jan 8, 2026
Merged
Conversation
🤖 My Senior Dev — Analysis Complete👤 For @khaliqgant📁 Expert in View your contributor analytics → 📊 2 files reviewed • 1 need attention
🚀 Open Interactive Review →The full interface unlocks features not available in GitHub:
💬 Chat here: 📖 View all 12 personas & slash commandsYou can interact with me by mentioning In PR comments or on any line of code:
Slash commands:
AI Personas (mention to get their perspective):
For the best experience, view this PR on myseniordev.com — includes AI chat, file annotations, and interactive reviews. |
kaposke
approved these changes
Jan 7, 2026
Contributor
kaposke
left a comment
There was a problem hiding this comment.
Works well. I wonder if we can improve this to make it optional in the future, like datadog (no year = current year, but you have to specify the same format for from and to).
No hard requirement for now though
hassan254-prog
pushed a commit
that referenced
this pull request
Jan 12, 2026
<!-- Describe the problem and your solution --> <!-- Issue ticket number and link (if applicable) --> <!-- Testing instructions (skip if just adding/editing providers) --> <!-- Summary by @propel-code-bot --> --- **Allow Custom Log Periods to Include Year** The PR updates the custom period parsing flow so users can specify four-digit years when entering log date ranges. It tightens the validation regex in `parsePeriod` and aligns the UI-supplied format string to include the year component. <details> <summary><strong>Key Changes</strong></summary> • Updated `parsePeriod` regex in `packages/webapp/src/utils/dates.ts` to require a four-digit year in both range endpoints • Adjusted `dateTimeFormat` in `packages/webapp/src/components/PeriodSelector.tsx` to `LLL dd, yyyy, HH:mm:ss` so formatted examples and parsed input include the year </details> <details> <summary><strong>Affected Areas</strong></summary> • packages/webapp/src/utils/dates.ts • packages/webapp/src/components/PeriodSelector.tsx </details> --- *This summary was automatically generated by @propel-code-bot*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow Custom Log Periods to Include Year
The PR updates the custom period parsing flow so users can specify four-digit years when entering log date ranges. It tightens the validation regex in
parsePeriodand aligns the UI-supplied format string to include the year component.Key Changes
• Updated
parsePeriodregex inpackages/webapp/src/utils/dates.tsto require a four-digit year in both range endpoints• Adjusted
dateTimeFormatinpackages/webapp/src/components/PeriodSelector.tsxtoLLL dd, yyyy, HH:mm:ssso formatted examples and parsed input include the yearAffected Areas
• packages/webapp/src/utils/dates.ts
• packages/webapp/src/components/PeriodSelector.tsx
This summary was automatically generated by @propel-code-bot