Merged
Conversation
🤖 My Senior Dev — Analysis Complete👤 For @TBonnin📁 Expert in View your contributor analytics → 📊 5 files reviewed • 1 need attention 🚨 High Risk:
🚀 Open Interactive Review →The full interface unlocks features not available in GitHub:
💬 Chat here: 📖 View all 12 personas & slash commandsYou can interact with me by mentioning In PR comments or on any line of code:
Slash commands:
AI Personas (mention to get their perspective):
For the best experience, view this PR on myseniordev.com — includes AI chat, file annotations, and interactive reviews. |
khaliqgant
approved these changes
Jan 13, 2026
d901a9d to
a63e9c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support page query parameter for public connections listing
Extends the public connections listing to accept a
pagequery parameter across the server handler, TypeScript types, Node SDK, and OpenAPI spec. The integration test suite now exercises multi-page pagination to confirm correct page slicing behavior.Key Changes
• Updated
packages/server/lib/controllers/connection/getConnections.tsvalidation schema to acceptpageand forward it toconnectionService.listConnections• Enhanced
packages/server/lib/controllers/connection/getConnections.integration.test.tswith pagination assertions across three pages• Extended
packages/node-client/lib/index.tslistConnectionshelper to accept and propagatepagein both modern and legacy call signatures• Aligned
packages/types/lib/connection/api/get.tsanddocs/spec.yamlto document the newpagequery parameterAffected Areas
•
packages/server/lib/controllers/connection/getConnections.ts•
packages/server/lib/controllers/connection/getConnections.integration.test.ts•
packages/node-client/lib/index.ts•
packages/types/lib/connection/api/get.ts•
docs/spec.yamlThis summary was automatically generated by @propel-code-bot