Skip to content

fix: fix create shared credentials#5404

Merged
hassan254-prog merged 1 commit intomasterfrom
wari/fix-create-shared-credentials
Feb 6, 2026
Merged

fix: fix create shared credentials#5404
hassan254-prog merged 1 commit intomasterfrom
wari/fix-create-shared-credentials

Conversation

@hassan254-prog
Copy link
Contributor

@hassan254-prog hassan254-prog commented Feb 6, 2026

Describe the problem and your solution

  • Since the unique constraint was removed from the table, this pr updates the related queries to handle that change correctly.

Align shared credential inserts with removed uniqueness constraint

The PR removes use of onConflict when inserting into providers_shared_credentials in both the config seeder and shared credentials service so that inserts succeed now that the name column no longer has a uniqueness constraint. Inserts now simply return the created rows without attempting to merge or ignore conflicts.

Key Changes

• Stopped calling onConflict('name').merge() in packages/shared/lib/seeders/config.seeder.ts when seeding shared credentials.
• Removed onConflict('name').ignore() in packages/shared/lib/services/shared-credentials.service.ts when creating shared credentials via the service.

Affected Areas

• packages/shared/lib/seeders/config.seeder.ts
• packages/shared/lib/services/shared-credentials.service.ts


This summary was automatically generated by @propel-code-bot

@hassan254-prog hassan254-prog marked this pull request as ready for review February 6, 2026 18:24
@hassan254-prog hassan254-prog requested review from a team and TBonnin and removed request for a team February 6, 2026 18:27
@hassan254-prog hassan254-prog added this pull request to the merge queue Feb 6, 2026
Merged via the queue into master with commit 6101b81 Feb 6, 2026
25 checks passed
@hassan254-prog hassan254-prog deleted the wari/fix-create-shared-credentials branch February 6, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants