fix(autodelete): don't filter out entries with count=0#5635
Merged
Conversation
Take into account entries in the records_count table that have count = 0 when selecting candidates for records autodelete so the entry is cleaned up
Contributor
There was a problem hiding this comment.
Review completed with no issues identified.
Status: No Issues Found | Risk: Low
Review Details
📁 1 files reviewed | 💬 0 comments
Instruction Files
├── .claude/
│ ├── agents/
│ │ └── nango-docs-migrator.md
│ └── skills/
│ ├── agent-builder-skill/
│ │ ├── EXAMPLES.md
│ │ └── SKILL.md
│ ├── creating-integration-docs/
│ │ └── SKILL.md
│ └── creating-skills-skill/
│ └── SKILL.md
├── AGENTS.md
└── GEMINI.md
marcindobry
approved these changes
Mar 16, 2026
kaposke
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Take into account entries in the records_count table that have
count = 0when selecting candidates for records autodelete so the entry is cleaned up. Right now those entries are kept in the db.This PR removes the filter that excluded
record_countsrows wherecountequals 0 when selecting auto-delete candidates. This ensures stale count entries with zero records are eligible for cleanup.This summary was automatically generated by @propel-code-bot