feat(providers): agent-powered oauth2 scope discovery#5701
Conversation
edc2342 to
765317c
Compare
765317c to
6b6702b
Compare
6b6702b to
fdcfaef
Compare
TBonnin
left a comment
There was a problem hiding this comment.
I am not against leveraging llms but I open the generated yaml, click on the first link (brex docs) and it gave me a 404. I then checked a random provider (docusign) and there are some scopes missing. Maybe I was super unlucky but doesn't make me super confident.
One can argue it is better than having nothing but it is also a giant pile of data that we are gonna need to maintain
18c1117 to
e654be8
Compare
Yes, I agree, it’s better than having nothing. We will also mention in the docs how we obtain this list to keep it transparent with our customers. I believe that, at the start, the list is not 💯 correct, but over time it will continue to improve through iterative updates run on a monthly basis. |
18f3b13 to
ba78a1a
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3572ef377c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 18871bb68a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 18b3df0342
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
18b3df0 to
8d7f511
Compare
|
I’ve updated the “Add” item to scroll with the rest. I initially thought anchoring it at the top looked better, but we can revisit this later if needed. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: edfd6272f5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| </Tooltip> | ||
| <Tooltip> | ||
| <TooltipTrigger asChild> | ||
| <Button type="button" size="icon" variant="ghost" onClick={() => void deleteAllScopes()}> |
There was a problem hiding this comment.
I don't think you need this type="button" everywhere?
| <Button type="button" size="icon" variant="ghost" onClick={() => void deleteAllScopes()}> | |
| <Button size="icon" variant="ghost" onClick={() => void deleteAllScopes()}> |
There was a problem hiding this comment.
The default type for this button is "submit", without type="button", clicking this button would trigger form submission.
Describe the problem and your solution
feat(providers):OAuth2scope catalog pipeline with API exposure and scope-picker UIThis PR introduces a full provider-scope catalog system centered on a new
packages/providers/providers.scopes.yamldataset and a large new automation script atscripts/validation/providers/sync-scopes.ts. The script supports deterministic and agent-driven modes, batch processing, duplicate-key/YAML sanitization, comment preservation, fallback todefault_scopes, validation guards, and CI check/write flows. It is wired into CI viatest:providers:scopes, monthly automated sync in.github/workflows/sync-provider-scopes.yaml, and updates in.github/workflows/validation.yaml.On the product side, provider APIs now include
availableScopesthrough updates inpackages/types/lib/providers/api.ts,packages/server/lib/formatters/provider.ts, and provider controllers. The web UI scope input was substantially refactored inpackages/webapp/src/components-v2/ScopesInput.tsxto a chips+combobox interaction using newpackages/webapp/src/components-v2/ui/combobox.tsx, with searchable suggestions, dedupe, paste/comma/enter parsing, and copy support, and integrated intoOAuthCreateForm.This summary was automatically generated by @propel-code-bot