chore: move authz types to shared package#5711
Merged
kaposke merged 1 commit intoMar 26, 2026
Merged
Conversation
rossmcewan
approved these changes
Mar 26, 2026
TBonnin
reviewed
Mar 26, 2026
| "@hookform/resolvers": "5.2.2", | ||
| "@mantine/core": "7.12.1", | ||
| "@mantine/prism": "5.10.5", | ||
| "@nangohq/authz": "file:../authz", |
Collaborator
There was a problem hiding this comment.
why do we need an authz package and not import the type from the types package directly?
Contributor
Author
There was a problem hiding this comment.
Types did move to the types package. The authz package currently holds exclusively packages/authz/lib/permissions.ts which is not a type. The types package currently only emits type declarations, so I didn't want to break that rule for this. And the other shared packages (shared, utils) are backend heavy.
I agree it seems overkill but I couldn't think of another way. Accepting suggestions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal to move authz types to the types package. Moves
permissionsto a newauthzpackage.The
authzpackage is very small containing only the permission definitions (for now at least).Q: why not moving
permissionstosharedorutils?A: because they are not imported by the frontend, for good reasons (they are heavy on backend specific stuff).
Lmk if you have better ideas.
It also updates server imports to consume the new authz package and wires the new package into TypeScript project references and package dependencies across the server and webapp.
This summary was automatically generated by @propel-code-bot