fix(webapp): allow clearing webhook urls in settings#5800
Merged
Conversation
Contributor
There was a problem hiding this comment.
No issues were found; the webhook URL clearing update appears safe and complete.
Status: No Issues Found | Risk: Low
Review Details
📁 2 files reviewed | 💬 0 comments
Instruction Files
└── .claude/
├── agents/
│ └── nango-docs-migrator.md
└── skills
kaposke
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the problem and your solution
Allow Empty Webhook URL Values in Webapp Settings Validation
This PR updates webhook URL validation in the web app so users can clear
primaryandsecondarywebhook URL fields in environment settings. Previously,validateUrlalways required a validhttp/httpsURL, which blocked saving empty values.The shared
validateUrlhelper now accepts an optionalallowEmptyflag and returns valid when the input is an empty string and that flag is enabled.Webhookssettings now callvalidateUrl(value, true)for both URL inputs, aligning behavior with the PR intent to allow clearing saved webhook URLs.This summary was automatically generated by @propel-code-bot