feat(logs): add log type for sync variant creation/deletion by rbwest · Pull Request #6012 · NangoHQ/nango

rbwest · 2026-04-30T18:11:45Z

Add log type for sync variant creation/deletion

NAN-5419: Add log type for sync variant creation/deletion

-Create/delete sync variant via API
-See new logs

linear · 2026-04-30T18:11:48Z

NAN-5419 Add log type for sync variant creation/deletion

cubic-dev-ai

1 issue found across 7 files

Confidence score: 2/5

There is a high-confidence, high-severity risk in packages/server/lib/controllers/sync/deleteSyncVariant.ts: if post-delete logging throws, the endpoint can still return a failure after the sync variant has already been removed.
This creates concrete user-facing inconsistency (client sees an error while data is already deleted), which raises regression and recovery risk enough to avoid calling this a safe merge yet.
Pay close attention to packages/server/lib/controllers/sync/deleteSyncVariant.ts - ensure logging errors are isolated so they don’t fail the delete flow after the primary operation succeeds.

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="packages/server/lib/controllers/sync/deleteSyncVariant.ts">

<violation number="1" location="packages/server/lib/controllers/sync/deleteSyncVariant.ts:75">
P1: Do not let post-delete logging failures fail this endpoint after the sync variant is already deleted.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f1d7fe2d18

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

TBonnin · 2026-04-30T21:45:54Z

+        integration: providerConfig?.unique_key ?? body.provider_config_key,
+        syncId: sync.id
+    });
+    await logCtx.success();


the log operation/info should reflect the actual result of the deletion (failure or success)

Hmm... the operation is always successful at this point since I do the log just at the end. I was originally thinking this was just to show a quick trail of successful operations, not show failed requests since they will see the failure mode in the response body immediately and then retry.

What do you think? Should I render logs for all the failed requests as well with specific context on why the request failed?

I think failed deletion should also be reported. Don't you think?

I've been going back and forth here tbh since it seems like extra noise and isn't something we do for other APIs currently, but I suppose you're right. I'll make the update and ping you when it's done.

isn't something we do for other APIs currently

Which API endpoints are reporting successful operations but not failed ones?

Sorry, I just meant not all API endpoints are represented in the logs (e.g. GET /records). So I wasn't initially sure if complete coverage of different error codes in the log output made sense, or if it was just noise.

I agree with you though and I've updated to output specific messages and the correct log type based on what happens in the endpoint. Let me know if there's any additional context I should be attaching to the logs here though.

…t-creationdeletion

…s available to logger

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 46191f2d17

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

cubic-dev-ai

1 issue found across 2 files (changes from recent commits).

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="packages/server/lib/controllers/sync/deleteSyncVariant.ts">

<violation number="1" location="packages/server/lib/controllers/sync/deleteSyncVariant.ts:68">
P1: The guard preventing deletion of the protected `base` variant was removed during this refactoring. Previously, the handler returned `invalid_variant` for `variant=base`; now requests proceed directly to `softDeleteSync`. Add back the check (as done in `postSyncVariant`) before processing the deletion to prevent removing a connection's canonical sync variant.</violation>
</file>

_{Tip: Review your code locally with the cubic CLI to iterate faster.
Fix all with cubic.}

…t-creationdeletion

chatgpt-codex-connector · 2026-05-06T17:35:22Z

💡 Codex Review

nango/packages/server/lib/controllers/sync/postSyncVariant.ts

Lines 178 to 186 in 1a4e79d

    
           await orchestrator.scheduleSync({ 
        
               nangoConnection: connection, 
        
               sync, 
        
               providerConfig, 
        
               syncName: sync.name, 
        
               syncVariant: sync.variant, 
        
               syncData, 
        
               logContextGetter 
        
           });

Mark variant operation failed when scheduling throws

logCtx is created at the start of this handler, but scheduleSync is awaited without a surrounding try/catch. If the orchestrator call rejects (for example due to orchestrator downtime), asyncWrapper will route the error to Express and return a 500 while this log operation never calls logCtx.failed(), leaving it stuck in running state. This introduces inaccurate Logs data for the new sync:create_variant operation and makes failed variant creations look in-progress indefinitely.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…t-creationdeletion

TBonnin

There is an overall question around why create/delete variant appears in the Nango logs while most of the other API operations don't but code lgtm

rbwest · 2026-05-12T16:53:55Z

There is an overall question around why create/delete variant appears in the Nango logs while most of the other API operations don't but code lgtm

This is mainly to give more visibility for support investigations. Full context from Kelvin here

rbwest added 3 commits April 30, 2026 14:08

Add new log types for sync variant created/deleted

ae3560d

Add name/icon for new log types in UI

23d3204

Fix tooltip being cutoff on first row with portal

f1d7fe2

cubic-dev-ai Bot reviewed Apr 30, 2026

View reviewed changes

Comment thread packages/server/lib/controllers/sync/deleteSyncVariant.ts Outdated

chatgpt-codex-connector Bot reviewed Apr 30, 2026

View reviewed changes

Comment thread packages/webapp/src/pages/Logs/constants.tsx

Fix missing search operation enum values and move log below response

e4c8444

rbwest requested a review from a team April 30, 2026 20:35

TBonnin requested changes Apr 30, 2026

View reviewed changes

Merge branch 'master' into ryan/nan-5419-add-log-type-for-sync-varian…

415dc17

…t-creationdeletion

TBonnin force-pushed the master branch from d1b1f44 to 3827b88 Compare May 2, 2026 15:55

rbwest added 2 commits May 5, 2026 16:16

Merge branch 'master' into ryan/nan-5419-add-log-type-for-sync-varian…

752308a

…t-creationdeletion

Log errors as well as success, adding additional context as it become…

46191f2

…s available to logger

chatgpt-codex-connector Bot reviewed May 5, 2026

View reviewed changes

Comment thread packages/server/lib/controllers/sync/deleteSyncVariant.ts

cubic-dev-ai Bot reviewed May 5, 2026

View reviewed changes

Comment thread packages/server/lib/controllers/sync/deleteSyncVariant.ts Outdated

rbwest added 3 commits May 5, 2026 17:15

Add back accidentally removed protection on base variant name

c8c515e

Fix missing operation data from provider config

d5d2e6d

Merge branch 'master' into ryan/nan-5419-add-log-type-for-sync-varian…

1a4e79d

…t-creationdeletion

superagent-security Bot added contributor:flagged Contributor flagged for review by trust analysis. pr:verified PR passed security analysis. labels May 6, 2026

TBonnin reviewed May 6, 2026

View reviewed changes

Comment thread packages/server/lib/controllers/sync/deleteSyncVariant.ts

Comment thread packages/server/lib/controllers/sync/deleteSyncVariant.ts Outdated

rbwest added 2 commits May 6, 2026 15:21

Inline log context and remove explicit typing

f2628bc

Cleanup error variable handling

95a9c2a

superagent-security Bot added contributor:verified Contributor passed trust analysis. and removed contributor:flagged Contributor flagged for review by trust analysis. labels May 6, 2026

Merge branch 'master' into ryan/nan-5419-add-log-type-for-sync-varian…

65ba140

…t-creationdeletion

TBonnin approved these changes May 7, 2026

View reviewed changes

rbwest added this pull request to the merge queue May 12, 2026

Merged via the queue into master with commit 3c7000a May 12, 2026
26 checks passed

rbwest deleted the ryan/nan-5419-add-log-type-for-sync-variant-creationdeletion branch May 12, 2026 17:03

Conversation

rbwest commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linear Bot commented Apr 30, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

TBonnin Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

rbwest May 1, 2026

Choose a reason for hiding this comment

Uh oh!

TBonnin May 4, 2026

Choose a reason for hiding this comment

Uh oh!

rbwest May 4, 2026

Choose a reason for hiding this comment

Uh oh!

TBonnin May 4, 2026

Choose a reason for hiding this comment

Uh oh!

rbwest May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented May 6, 2026

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

TBonnin left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rbwest commented May 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

rbwest commented Apr 30, 2026 •

edited

Loading

rbwest May 5, 2026 •

edited

Loading

TBonnin left a comment •

edited

Loading