Skip to content

fix(utils): add additional retry network error codes from env vars#6077

Merged
rossmcewan merged 4 commits into
masterfrom
ross/NAN-5452/retry-on-und-err-socket
May 11, 2026
Merged

fix(utils): add additional retry network error codes from env vars#6077
rossmcewan merged 4 commits into
masterfrom
ross/NAN-5452/retry-on-und-err-socket

Conversation

@rossmcewan
Copy link
Copy Markdown
Contributor

No description provided.

@linear
Copy link
Copy Markdown

linear Bot commented May 7, 2026

NAN-5452

@superagent-security superagent-security Bot added contributor:verified Contributor passed trust analysis. pr:verified PR passed security analysis. labels May 7, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2cfa3f2b43

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/utils/lib/retry.ts Outdated
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files

Confidence score: 4/5

  • This PR is likely safe to merge with minimal risk, since the only reported issue is moderate severity (5/10) and scoped to retry-code normalization logic.
  • In packages/utils/lib/retry.ts, env-provided error codes should be trimmed/filtered before being added to networkError; whitespace or empty entries can silently stop expected retries.
  • Pay close attention to packages/utils/lib/retry.ts - retry behavior may be unintentionally skipped when error-code env values include extra spaces or blank tokens.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="packages/utils/lib/retry.ts">

<violation number="1" location="packages/utils/lib/retry.ts:108">
P2: Normalize env-provided error codes (trim/filter) before adding them to `networkError`; otherwise whitespace/empty entries can silently prevent retries.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.

Comment thread packages/utils/lib/retry.ts Outdated
@rossmcewan rossmcewan changed the title Ross/nan 5452/retry on und err socket fix(utils): add additional retry network error codes from env vars May 8, 2026
@rossmcewan rossmcewan requested a review from a team May 8, 2026 07:01
Comment thread packages/utils/lib/retry.ts
Comment thread packages/utils/lib/retry.unit.test.ts Outdated
@rossmcewan rossmcewan added this pull request to the merge queue May 11, 2026
Merged via the queue into master with commit fd331f0 May 11, 2026
26 checks passed
@rossmcewan rossmcewan deleted the ross/NAN-5452/retry-on-und-err-socket branch May 11, 2026 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor:verified Contributor passed trust analysis. pr:verified PR passed security analysis.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants