fix(jira-data-center): update domain pattern for Jira Data Center #6135
Merged
hassan254-prog merged 2 commits intoMay 14, 2026
Merged
Conversation
…ount Modified the regex pattern for the domain field in the Jira Data Center configuration to allow for a more flexible URL structure, accommodating optional port numbers and path segments. E.g. for customers who are using APIM or similar rewrites.
hassan254-prog
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified the regex pattern for the domain field in the Jira Data Center configuration to allow for a more flexible URL structure, accommodating optional port numbers and path segments. E.g. for customers who are using APIM or similar rewrites.
The pattern ^[a-zA-Z0-9.-]+(:\d+(/[a-zA-Z0-9.-]*)?)?$ only allows a path segment after a port, and even then just one segment of [a-zA-Z0-9.-] chars. So staging.customer.com/staging/external fails because there's no :port before the path, and /staging/external is two segments anyway.
This pattern would cover both the current cases and the APIM case:
^[a-zA-Z0-9.-]+(:\d+)?(/[a-zA-Z0-9._~-]+)*/?$
Breakdown:
[a-zA-Z0-9.-]+ — host (unchanged)
(:\d+)? — optional port (relaxed: no longer requires a path to follow)
(/[a-zA-Z0-9._~-]+)* — zero or more path segments, each allowing the usual safe URL chars
/?$ — optional trailing slash
That would accept:
jira.company.com✅jira.company.com:8080✅jira.company.com:8080/jira✅ (already worked)staging.customer.com/staging/external✅ (the APIM case)staging.customer.com/staging/external/✅https://nango-community.slack.com/archives/C079A04T89L/p1778607496672159